Conversation
Fix `needQuotes` allowing every code point from U+00AF up to be unquoted. E.g. `'My»Sheet'!RC[-2]` translated to A1 as `My»Sheet!A1`, and Excel refuses that in formula entry and triggers repair if it sees it in a file. Testing every code point in U+00AF-U+FFFF in Excel found 4,295 refused ones, interleaved with accepted ones in a way that doesn't seem to match any clear Unicode category or pattern. So they are added as a generated character class. Nothing assigned above U+FFFF is refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
needQuotesallowing every code point from U+00AF up to be unquoted.E.g.
'My»Sheet'!RC[-2]gets translated to A1 asMy»Sheet!A1, and Excel refuses that in formula entry and triggers repair if it sees it in a file.Testing every code point in U+00AF-U+FFFF in Excel found 4,295 refused ones, interleaved with accepted ones in a way that doesn't seem to match any clear Unicode category or pattern. So they are added as a generated character class. Nothing assigned above U+FFFF is refused.