Repository navigation
Conversation
Reject an empty quoted entry type instead of silently ignoring the directive. Empty optional fields continue to preserve subsequent columns. Follow-up to bootc-dev#2534. Assisted-by: AI Signed-off-by: Natsu <139412824+ddy314@users.noreply.github.com>
ddy314
force-pushed
the
fix/sysusers-empty-entry-type
branch
from
October 16, 2026 13:52
eeef64e to
b81d1b5
Compare
ddy314
marked this pull request as ready for review
October 16, 2026 13:52
cgwalters
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty quoted entry type currently falls through as an unknown directive and is silently ignored. Reject it as a parse failure while continuing to allow empty optional fields.
Follow-up to #2534 and the maintainer-approved review discussion: #2534 (comment).
Validation: the added case fails before the fix; all 13
bootc-sysuserstests, targeted strict Clippy, formatting, andgit diff --checkpass. An independent code review found no actionable issues.Assisted-by: AI. Implementation and tests were prepared with AI assistance. The contributor reviewed the patch and explicitly authorized DCO signoff and marking this PR ready for review.