Skip to content

test: expand unit test coverage for AutoCompletion, AutoCompletePopupWindow, ParameterizedCompletionContext - #128

Merged
bobbylight merged 1 commit into
masterfrom
test/expand-autocomplete-coverage
Aug 27, 2026
Merged

test: expand unit test coverage for AutoCompletion, AutoCompletePopupWindow, ParameterizedCompletionContext#128
bobbylight merged 1 commit into
masterfrom
test/expand-autocomplete-coverage

Conversation

@bobbylight

Copy link
Copy Markdown
Owner

Summary

Expands unit test coverage across three core classes: AutoCompletePopupWindow (previously untested), AutoCompletion, and ParameterizedCompletionContext.

Details

  • Added AutoCompletePopupWindowTest, covering key navigation actions (Up/Down/Home/End/PageUp/PageDown with wraparound), Enter/Tab/Escape handling, mouse double-click insertion, getSelection() before/after hiding, setCompletions, list cell renderer round-trip, description window color/size (before and after the window is created), disposeDescWindow, toggleDescriptionWindow edge cases, the static install/uninstallDescWindowToggleKey helpers, updateUI, and setVisible lifecycle behavior.
  • Extended AutoCompletionTest with tests for getCompletionProvider, getDescWindowFactory/setDescWindowFactory (verifying the custom factory is actually used to build the description window), setDescriptionWindowSize applied lazily before the popup exists, isAutoActivationEnabled/setAutoActivationEnabled round-tripping, and both branches of parameterized completion assistance for zero-parameter completions (typed vs. untyped start character).
  • Extended ParameterizedCompletionContextTest with tests for the NextChoiceAction fallback path when the parameter choices window isn't visible, and for ClosingAction's "closing paren is part of the argument text" branch.

Test plan

  • ./gradlew clean build passes locally (checkstyle, spotbugs, and all unit tests).

🤖 Generated with Claude Code

@bobbylight
bobbylight marked this pull request as ready for review August 27, 2026 01:30
@bobbylight bobbylight added this to the 4.0.0 milestone Aug 27, 2026
@bobbylight bobbylight self-assigned this Aug 27, 2026
@bobbylight
bobbylight force-pushed the test/expand-autocomplete-coverage branch from b6b0cfb to 5a8a207 Compare August 27, 2026 01:33
…ed context

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@bobbylight
bobbylight force-pushed the test/expand-autocomplete-coverage branch from 5a8a207 to 29e43be Compare August 27, 2026 01:59
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.52%. Comparing base (e7521ba) to head (29e43be).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     74.33%   77.52%   +3.19%     
- Complexity      713      742      +29     
============================================
  Files            36       36              
  Lines          3253     3253              
  Branches        520      520              
============================================
+ Hits           2418     2522     +104     
+ Misses          540      435     -105     
- Partials        295      296       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobbylight
bobbylight merged commit 20c34c0 into master Aug 27, 2026
4 checks passed
@bobbylight
bobbylight deleted the test/expand-autocomplete-coverage branch August 27, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants