Repository navigation
Add list() to transactions - #8
Merged
ubcodes merged 6 commits intoSep 23, 2026
Merged
Conversation
2 of 3 tasks
…reated row is found.
ListOptions is on main after the ledgers/balances list work; this keeps transactions().list() building on that copy.
A newly created row can sit on page one, so inclusion alone would not catch Core ignoring offset.
Keep both changelog entries: transactions list from this PR and listByBalanceId from main after blnkfinance#11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
transactions().list(), wrappingGET /transactions. It takes the same optionalListOptions(limit,offset) introduced for ledgers and balances, sent as query parameters. Unset fields fall back to Core's defaults, which for this route arelimit=20andoffset=0.Core's
GetAllTransactionshandler silently falls back to its defaults on an invalidlimitoroffsetrather than returning400. The SDK rejects those values client-side with a400instead, so caller mistakes stay visible.Builds on #, which introduces
ListOptionsandListValidators. Once that merges, this PR reduces to a single commit.Changes
Transactions:list()andlist(ListOptions).TransactionsTest: newGET all transactionsgroup with four cases (plain call, query rendering, validation rejection, error handling).README.md: paging example extended to transactions, with the differing default noted.CHANGELOG.md: bullet under Unreleased.Test plan
mvn testoffline: 560 run, 0 failures, 57 skipped (live suites gated onBLNK_E2E).