Repository navigation
Add listByBalanceId for GET /balance-monitors/balances/:id - #11
Merged
Merged
Conversation
…hout listing every monitor.
Keeps listByBalanceId on current main after the ledgers/balances list work landed.
Null should fail the same way as empty so callers never send GET .../balances/.
ubcodes
added a commit
to chidoziemfrancis/blnk-java
that referenced
this pull request
Sep 23, 2026
Keep both changelog entries: transactions list from this PR and listByBalanceId from main after blnkfinance#11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
balanceMonitor().listByBalanceId(balanceId), wrapping Core'sGET /balance-monitors/balances/:balance_id(api/api.go). Existinglist()still returns every monitor./,?, and#cannot split the path; empty or whitespace-only ids return400with no request.ListOptionskeys are N/A. CHANGELOG notes Core ~0.14.x (SDK aligned with 0.15.4).Test plan
mvn -o clean test: 562 run, 0 failures, 59 skipped (live suites gated onBLNK_E2E=1)BLNK_E2E=1: create a monitor on a balance and GET by that id (Core was down locally; tests skip rather than fake-pass)/?#, empty/whitespace rejection, transport errors