Feature: config file deletion from cli command - #321
Closed
emma31-dev wants to merge 13 commits into
Closed
Conversation
emma31-dev
force-pushed
the
feat/config-deletion
branch
2 times, most recently
from
September 11, 2026 13:13
f53ea40 to
1bb0891
Compare
Author
|
@vadim-anfv please take a look and share your taughts if there is something i missed |
emma31-dev
force-pushed
the
feat/config-deletion
branch
2 times, most recently
from
September 11, 2026 16:56
6aa2e6e to
19bb79f
Compare
Combine `prepare_wallet_db_dir` and `load_wallet_config` into a single function that returns the database path alongside wallet options and network, reducing code duplication in the `WalletRuntime` loader. Signed-off-by: emma31-dev <emmanuelfidel07@gmail.com>
Introduce a new `delete-config` subcommand that removes a wallet's configuration. If it was the last wallet in `config.toml`, the configuration file itself is deleted; otherwise the file is rewritten without the wallet entry. The subcommand is gated behind the `repl` feature and rejects execution in REPL mode, since the wallet for the current session is already loaded.
emma31-dev
force-pushed
the
feat/config-deletion
branch
from
September 11, 2026 17:39
7944d45 to
8fde4f5
Compare
Split the combined helper into separate functions for preparing the wallet database directory and loading wallet config.
emma31-dev
force-pushed
the
feat/config-deletion
branch
from
September 11, 2026 18:18
d5bf6d0 to
bd93eda
Compare
emma31-dev
changed the title
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is from issue #310 to add support for deletion of config file from a cli command.
Notes to the reviewers
The changes are still incomplete as documentation and feature gating possibility in sight
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md