Repository navigation
Read finding severities with ast instead of a backtracking regex - #52
Merged
Merged
Conversation
test_compatibility.py found each _f(...) call in scoring.py with a regular expression whose nested repetition CodeQL flags as able to backtrack exponentially (py/redos). It now walks the parsed source, which also reads a computed severity directly rather than inferring it from text. The result is unchanged: 32 finding IDs, two with computed severities. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CodeQL alert #5 (
py/redos, high) intests/test_compatibility.py, added in #51._constructed()found each_f(...)call inscoring.pywith a regular expression whose nested repetition can backtrack exponentially. It now walks the parsed source withast, which also reads a computed severity directly instead of inferring it from the text. The result is the same: 32 finding IDs, with FS-001 and PRIV-003 the only ones whose severity is computed.The only input was this repository's own source, so nothing could have supplied a hostile string. The change clears the alert and makes the test less fragile.
Locally 512 tests pass and 13 skip without network.
🤖 Generated with Claude Code