Repository navigation
Repo cleanup: internal notes, Finder files and dead helpers - #18
Merged
Merged
Conversation
- _reviews/ (39 review notes from July) is internal and no longer tracked; it is ignored now, and the guard fails if it or students/ is tracked. - .DS_Store and lectures/.DS_Store are untracked and ignored. - helpers/check_svgs.sh and helpers/convert-pdf.py were referenced by nothing; the second only ran with a path on one old machine. - README: outputs and folders that no longer exist are gone, the link to the helper section works, pyproject has a description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
_reviews/(39 review notes from July) is no longer tracked. It is ignored, and the guard now fails if a top-level_reviews/orstudents/is tracked, as it already did forsolutions/..DS_Storeandlectures/.DS_Storeare untracked and ignored.helpers/check_svgs.shandhelpers/convert-pdf.pywere referenced by nothing. The second only ran with a hard-coded path on one old machine.pyproject.tomlhas a description.Nothing that is rendered changes: no page, deck or tutorial refers to the removed files.
Note
The review notes stay readable in the history of this repository. Removing them there would need a history rewrite and a force-push of
main, which this PR does not do.