Repository navigation
Use StructArmed on QA - #1155
samsonasik wants to merge 3 commits into
Conversation
|
@jeromegamez ready for review/merge 👍 |
|
Hey there 👋🏻, thank you for taking the time to provide this well written PR. However, while I see the benefit for large projects/apps/services, I don't think it's something I want to implement in this library. The contracts are simple, they all have exactly one implementation. The structure is simple, I can review the few PRs, and quite easily see and address "design violations" of the architecture. The I do appreciate and thank your effort, and but I'm the only maintainer, and unless the SDK becomes unwieldly large (it isn't in my view) and/or has more maintainers and/or a lot of contributors, I don't see it as a tool for my workflows. Thanks again! |
|
That's fine, feel free to use it in the future if you think it is usefull ;) |
This PR to make use of StructArmed.
This PR start apply StructArmed with initialize using
PSR4andCODEQUALITYpreset and already help fix 19 violations.On
CODEQUALITYpreset apply changes to make anonymous functionstaticwhen possible and add_separator on big numbers.Applied with:
I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.
I also register to github action and composer script.