Skip to content

Use StructArmed on QA - #1155

Closed
samsonasik wants to merge 3 commits into
beste:8.xfrom
samsonasik:use-structarmed-on-qa
Closed

samsonasik wants to merge 3 commits into
beste:8.xfrom
samsonasik:use-structarmed-on-qa

Conversation

@samsonasik

@samsonasik samsonasik commented Oct 16, 2026 •

Copy link
Copy Markdown

This PR to make use of StructArmed.

This PR start apply StructArmed with initialize using PSR4 and CODEQUALITY preset and already help fix 19 violations.

On CODEQUALITY preset apply changes to make anonymous function static when possible and add _ separator on big numbers.

Applied with:

composer structarmed:fix

I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.

I also register to github action and composer script.

@samsonasik

Copy link
Copy Markdown
Author

@jeromegamez ready for review/merge 👍

@jeromegamez

Copy link
Copy Markdown
Member

Hey there 👋🏻, thank you for taking the time to provide this well written PR.

However, while I see the benefit for large projects/apps/services, I don't think it's something I want to implement in this library. The contracts are simple, they all have exactly one implementation. The structure is simple, I can review the few PRs, and quite easily see and address "design violations" of the architecture.

The static qualifiers can be implemented with a rector/PHP CS Fixer rule.

I do appreciate and thank your effort, and but I'm the only maintainer, and unless the SDK becomes unwieldly large (it isn't in my view) and/or has more maintainers and/or a lot of contributors, I don't see it as a tool for my workflows.

Thanks again!

@samsonasik
samsonasik deleted the use-structarmed-on-qa branch October 16, 2026 14:49
@samsonasik

Copy link
Copy Markdown
Author

That's fine, feel free to use it in the future if you think it is usefull ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants