Skip to content

feat(library-ci): tests: true runs the repository's bulk test command - #33

Merged
igorlamos merged 2 commits into
mainfrom
claude/library-ci-tests
Nov 21, 2026
Merged

igorlamos merged 2 commits into
mainfrom
claude/library-ci-tests

Conversation

@beplus-agent-claude

Copy link
Copy Markdown
Contributor

What

library-ci.yml's "Run tests (when available)" step only echoed "Tests will be added in the future". A library with no test job of its own (beplus/api: api-core 5 tests, api-codegen 12) was built and change-verified in CI, and its tests ran on developers' machines only (found on beplus/api#10, Stack #11).

New input tests (boolean, default false):

  • On: after rush rebuild, the step runs node ./common/scripts/install-run-rush.js test --verbose. A failed suite fails the job.
  • On, but common/config/rush/command-line.json has no bulk test command: a ::notice, a line in the job summary saying no tests ran, and the step passes.
  • Off: the step says the tests are off and passes, as before.

It runs over every project, as the build does. This job's PR gate passes no projects, so there is no impacted set: the build is a whole-repo rush rebuild, and the tests use the same scope.

Why off by default

The input style here is that every optional step defaults to OFF, so moving v2 changes no caller. In this case off is also the only safe default. Every library that already has a bulk test runs it in a test job of its own: actions, agents, ai, automations, computers, docs, editor, flows, i18n, integrations, inui, kb, messaging, mind, rush, voice, workbench. Several of those jobs run against a Postgres or Neo4j service, which this job does not start. If tests were detected and on by default, the move of v2 would run their suites twice, or without their database.

The commits

The step stays in place (no if:), so scripts/verify-callers.mjs still sees every caller's steps as unchanged: 15 workflows fail before this change and the same 15 fail after it (the cache-step renames of 2.17.0 and the library-publish redesign); every */ci keeps "Run tests (when available)".

  1. docs(library-ci): README, "Tests in library-ci" (pushed by the bot).
  2. feat(library-ci): the input and the step. Pushed by Igor, because the bot App has no workflows permission.

Tests

  • The step's script, extracted with yq, was run against fake repositories: a JSONC command-line.json with a bulk test (comments and trailing commas included) runs rush test --verbose; a global test and a missing file give the notice and pass; tests: false passes.
  • The same script was run against beplus/api with its test command added (beplus/api follow-up): 2 operations passed (api-core 5/5, api-codegen 12/12), and @beplus/api-model is a no-op.

After merge

Tag v2.18.0 and move v2. Only then may a caller set tests: true: before that it is an unknown input, and the workflow is invalid. The first caller is beplus/api.

beplus-agent-claude Bot and others added 2 commits November 21, 2026 09:51
Co-Authored-By: Igor Lamos <igor@be.plus>
…mand

The "Run tests (when available)" step only echoed "Tests will be added in the
future", so a library without a test job of its own (beplus/api) built and
change-verified in CI but ran its tests on developers' machines only.

With `tests: true` the step runs `rush test --verbose` after the build, over
every project as `rush rebuild` is (the job's gate selects no projects). A
repository with no bulk `test` in command-line.json gets a notice and a summary
line, and the step passes. Off by default: the libraries that already have a
bulk `test` run it in their own `test` job, several against Postgres or Neo4j,
which this job does not start. The step stays in place, so verify-callers sees
every caller's steps unchanged.

Co-Authored-By: Igor Lamos <igor@be.plus>
@beplus-agent-claude
beplus-agent-claude Bot marked this pull request as ready for review November 21, 2026 15:15
@igorlamos igorlamos self-assigned this Nov 21, 2026
@igorlamos
igorlamos merged commit ae38ec8 into main Nov 21, 2026
@igorlamos
igorlamos deleted the claude/library-ci-tests branch November 21, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant