Repository navigation
feat(library-ci): tests: true runs the repository's bulk test command - #33
Merged
Merged
Conversation
Co-Authored-By: Igor Lamos <igor@be.plus>
…mand The "Run tests (when available)" step only echoed "Tests will be added in the future", so a library without a test job of its own (beplus/api) built and change-verified in CI but ran its tests on developers' machines only. With `tests: true` the step runs `rush test --verbose` after the build, over every project as `rush rebuild` is (the job's gate selects no projects). A repository with no bulk `test` in command-line.json gets a notice and a summary line, and the step passes. Off by default: the libraries that already have a bulk `test` run it in their own `test` job, several against Postgres or Neo4j, which this job does not start. The step stays in place, so verify-callers sees every caller's steps unchanged. Co-Authored-By: Igor Lamos <igor@be.plus>
igorlamos
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
library-ci.yml's "Run tests (when available)" step only echoed "Tests will be added in the future". A library with notestjob of its own (beplus/api: api-core 5 tests, api-codegen 12) was built and change-verified in CI, and its tests ran on developers' machines only (found on beplus/api#10, Stack #11).New input
tests(boolean, defaultfalse):rush rebuild, the step runsnode ./common/scripts/install-run-rush.js test --verbose. A failed suite fails the job.common/config/rush/command-line.jsonhas no bulktestcommand: a::notice, a line in the job summary saying no tests ran, and the step passes.It runs over every project, as the build does. This job's PR gate passes no
projects, so there is no impacted set: the build is a whole-reporush rebuild, and the tests use the same scope.Why off by default
The input style here is that every optional step defaults to OFF, so moving
v2changes no caller. In this case off is also the only safe default. Every library that already has a bulktestruns it in atestjob of its own: actions, agents, ai, automations, computers, docs, editor, flows, i18n, integrations, inui, kb, messaging, mind, rush, voice, workbench. Several of those jobs run against a Postgres or Neo4j service, which this job does not start. Iftestswere detected and on by default, the move ofv2would run their suites twice, or without their database.The commits
The step stays in place (no
if:), soscripts/verify-callers.mjsstill sees every caller's steps as unchanged: 15 workflows fail before this change and the same 15 fail after it (the cache-step renames of 2.17.0 and the library-publish redesign); every*/cikeeps "Run tests (when available)".docs(library-ci): README, "Tests in library-ci" (pushed by the bot).feat(library-ci): the input and the step. Pushed by Igor, because the bot App has noworkflowspermission.Tests
yq, was run against fake repositories: a JSONCcommand-line.jsonwith a bulktest(comments and trailing commas included) runsrush test --verbose; a globaltestand a missing file give the notice and pass;tests: falsepasses.testcommand added (beplus/api follow-up): 2 operations passed (api-core 5/5, api-codegen 12/12), and@beplus/api-modelis a no-op.After merge
Tag
v2.18.0and movev2. Only then may a caller settests: true: before that it is an unknown input, and the workflow is invalid. The first caller is beplus/api.