Repository navigation
fix(cli): BE_NPM_CHECK asks for an npm alias's real package, not the alias - #31
Merged
Merged
Conversation
…alias A dependency such as "@beplus/docs-legacy": "npm:@beplus/docs@0.4.2" is fetched as @beplus/docs, but the check asked the registry for @beplus/docs-legacy, got a 404 and failed the job (Mountaineer's console, ironmountain-cz/monorepo#563). It now reads the package after `npm:`, and skips an alias to a package outside @beplus. Co-Authored-By: Igor Lamos <igor@be.plus>
igorlamos
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BE_NPM_CHECKnow asks the registry for an npm alias's real package, not for the alias's name.Mountaineer's console has
"@beplus/docs-legacy": "npm:@beplus/docs@0.4.2". pnpm fetches that as@beplus/docs, but the check took the key and asked for@beplus/docs-legacy. It got a 404 and failed the job. That is the redCheck Locale Translations / checkson ironmountain-cz/monorepo#563, the firstapp-ci.ymlcaller with an aliased dependency. npm sign-in itself worked.How
The jq that lists each package's
@beplusdependencies now:npm:as the package afternpm:, scoped or not, with or without a version;@beplus, which is not this registry's to serve;@beplus;workspace:dependencies.cli/README.mdsays so.Checked
I extracted the step's script from
cli/action.ymland ran it with a stand-innpmthat answers like a real registry, but gives a 404 for@beplus/docs-legacy:package.jsonfromdev,mainfails with::error::@beplus/docs-legacy: npm error 404, as in CI;@beplus/docsamong them, and exits 0;@beplus/actions(fromplain-alias),@beplus/bare-real(no version),@beplus/docs,@beplus/uixand@beplus/i18n-tools, and skips the lodash alias and theworkspace:one.test-cli.yml's registry case (no token, so the anonymous stub) is unchanged.Release
A patch, v2.16.2, and
v2moved to it. #563 then only needs its check re-run.