Skip to content

ci: the PR gate — never a draft, and in a stack only the top PR - #12

Merged
igorlamos merged 1 commit into
devfrom
claude/pr-gate
Nov 18, 2026
Merged

igorlamos merged 1 commit into
devfrom
claude/pr-gate

Conversation

@beplus-agent-claude

Copy link
Copy Markdown
Contributor

What

This PR turns on setup-beplus's PR gate for this repository's PR workflows. The gate is beplus/setup-beplus#32, described in pr-gate/PR-GATE.md.

  • A draft runs nothing. pull_request now also triggers on ready_for_review, so marking a PR ready starts its checks.
  • In a stack, only the top PR runs. Its tree holds every PR below it, and the lower PRs report "skipped" with the reason.
  • The branches: filter is gone. A stack's top PR is based on the PR below it, so branches: [dev] let only the bottom PR run, never the one that holds the stack.
  • A paths: filter now lives in the gate (gate-paths), which reads the whole stack's diff. The filter saw only the top PR's own commits.
  • Workflows here:
    • library-ci and docs-pages take pr-gate: true.
    • A job of this repository's own waits for a gate job.
    • Where a job read the PR's base, it now reads the stack's root, so it claims that branch's environment and secrets.

Needs

setup-beplus v2.17.0, with v2 moved to it. Until then pr-gate is an unknown input. Merge after setup-beplus#32.

setup-beplus's PR gate (pr-gate/PR-GATE.md, v2.17.0) decides inside each run
whether a pull request's checks run: never on a draft (marking it ready starts
them), and in a stack only on the top PR, whose tree holds every PR below it;
the PRs below report "skipped". A stack merges in one go, so dev ends at the
tree the top PR tested.

- `pull_request` runs on opened, synchronize, reopened and ready_for_review,
  with no `branches:` filter: a stack's top PR is based on the PR below it, so
  the filter let only the BOTTOM PR run, never the one that holds the stack.
- A `paths:` filter moved into the gate (`gate-paths`), which reads the whole
  stack's diff: the filter saw only the top PR's own commits.
- library-ci and docs-pages take `pr-gate: true`; a job of this repository's own
  waits for a `gate` job, and where it read the PR's base it reads the stack's
  root (dev), so it claims dev's environment and secrets.

Needs setup-beplus v2.17.0 (v2 moved): until then `pr-gate` is an unknown input.

Co-Authored-By: Igor Lamos <igor@be.plus>
@beplus-agent-claude
beplus-agent-claude Bot marked this pull request as ready for review November 16, 2026 21:53
@igorlamos igorlamos self-assigned this Nov 18, 2026
@igorlamos
igorlamos merged commit b42a5a9 into dev Nov 18, 2026
8 of 9 checks passed
@igorlamos
igorlamos deleted the claude/pr-gate branch November 18, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant