fix: missing root exports, and three guides that described the wrong behaviour - #17
Merged
Merged
Conversation
…behaviour The work landed in #16. Its squash subject lost the Conventional Commit prefix -- my mistake on the merge, not the author's -- so release-please skipped the merge and these fixes would never have reached a release. This commit carries the record. It changes no code: #16 is already on master. * FullGrpcClientSettingsProtocol, GrpcChannelExtrasProtocol and GrpcObservabilityExtrasProtocol are exported from the package root, where the other eleven protocols of that module already were. RetryMetricsProtocol and CircuitBreakerMetricsProtocol joined protocols.__all__, which a star import had been missing. MethodCircuitState left circuit_breaker.__all__: it is mutable internal bookkeeping in no public signature, and it stays importable by name. * The health guide claimed the factory forwards neither options nor compression. It forwards both. It also placed HealthCheckerNotRunningError in the health module behind the health extra; the error is in grpc_client_kit.errors, is a root export, and catching it needs no extra. And probes are not always about the overall server: the checker takes a service name and the factory forwards it. * The resilience and deadline guides both said there is no settings block for their layer. There is one, and the factory reads it. * hasattr(grpc_client_kit, "HealthChecker") raising ImportError on an install without the extra is deliberate -- downgrading it would make a broken install look like a name that never existed -- and is now written down where a caller looks, rather than being folklore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes. One empty commit restoring a record the merge of #16 lost.
I squash-merged #16 using its pull request title as the commit subject, and that title was written as prose rather than as a Conventional Commit. release-please parses subjects, found nothing releasable since the last tag, and opened no release pull request — so the fixes would have sat on
masterindefinitely. My mistake on the merge, not the author's.The commit message here carries the same summary under a
fix:subject, so the pending release is computed and the changelog says what changed. The full detail, the reproductions and the tests are in #16.The diff is empty by design. Reviewing it means reading #16.