Repository navigation
[PAC-6] Configuration registry completion (VarSpec tiers; TEST_DATA_DIR removed) - #617
Open
physics515 wants to merge 1 commit into
Open
physics515 wants to merge 1 commit into
physics515 wants to merge 1 commit into
Conversation
…the VarSpec registry (fixtures are paths, not configuration)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the PAC-5a/PAC-6 configuration registry (1.0-plan §3 PAC-5a/PAC-6 row + §6 W8 open lane + §8 wording per decision 21). No ROADMAP line exists for this slice; issue #439.
What changed
TEST_DATA_DIRVarSpec removed from the registry inweft-server/src/settings.rs(registry 104 -> 103; size assertion and Test-tier allowlist updated).weftdb::data_dirdrops the TEST_DATA_DIR leg; test suites are handed their fixture directory through the StableWEFT_DATA_DIRvariable instead. Every suite/bench that set TEST_DATA_DIR now sets WEFT_DATA_DIR (weftdb, weft-server, weft-orchestration tests and benches).Verification (full bar on this exact tree)
cargo +nightly fmt --all -- --check— passRUSTFLAGS=-D warnings cargo check --workspace --all-targets --locked— passSalvage note: implemented by the W8 loop, whose run timed out; the parent salvaged the worktree diff, re-verified, rebased onto current main (DECISIONS.md union) and re-ran the full bar green before publishing. Per the wave batch pattern this PR stops for the wave-end batch merge.