Skip to content

fix(ci): verify supplied installer checksums - #2192

Open
codeforester wants to merge 1 commit into
mainfrom
security/2188-20260910-verify-supplied-base-installer-checksums-before-downstream-p
Open

fix(ci): verify supplied installer checksums#2192
codeforester wants to merge 1 commit into
mainfrom
security/2188-20260910-verify-supplied-base-installer-checksums-before-downstream-p

Conversation

@codeforester

@codeforester codeforester commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Always hash the exact tagged Base install.sh bytes used by downstream automation.
  • Reject malformed supplied checksums before the update.
  • Reject valid-format supplied checksums that do not match the downloaded release artifact.
  • Persist only the verified downloaded digest into downstream pins.

Issue

Fixes #2188

Validation

  • bash -n .github/workflows/downstream-version-bumps.yml
  • env -u BASE_HOME BASE_CACHE_DIR=/private/tmp/base-issue-2188-cache PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest -q tests/test_github_workflows.py tests/test_downstream_version_bump.py
  • 46 passed
  • git diff --check

Security Notes

Supplied checksums are now verified against the immutable release-tag artifact before downstream pins are written.

@codeforester
codeforester requested a review from a team as a code owner September 10, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify supplied Base installer checksums before downstream pins

1 participant