Skip to content

fix(trust): preserve workspace in generated guidance - #2191

Open
codeforester wants to merge 1 commit into
mainfrom
bug/2187-20260910-preserve-workspace-context-in-generated-manifest-trust-comma
Open

fix(trust): preserve workspace in generated guidance#2191
codeforester wants to merge 1 commit into
mainfrom
bug/2187-20260910-preserve-workspace-context-in-generated-manifest-trust-comma

Conversation

@codeforester

@codeforester codeforester commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Include the resolved workspace in generated trust allow commands.
  • Include the same workspace context in review commands emitted by status and blocked-command guidance.
  • Shell-quote generated command arguments so non-default workspaces and paths with spaces remain executable.

The current affected surface is base trust status and blocked guidance; workspace onboarding does not currently emit trust commands on main.

Issue

Fixes #2187

Validation

  • env -u BASE_HOME BASE_CACHE_DIR=/private/tmp/base-issue-2187-cache PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest -q cli/python/base_trust/tests/test_engine.py cli/python/base_trust/tests/test_command_error_paths.py
  • 31 passed, 18 subtests passed
  • git diff --check

@codeforester
codeforester requested a review from a team as a code owner September 10, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve workspace context in generated manifest-trust commands

1 participant