Ship the two health probes instead of leaving them as examples - #39
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Moves reusable health probes into hotcell-server as opt-in operations.
Changes:
- Adds
health.echoandhealth.reopenwith tests. - Updates examples, clients, and deployment documentation.
- Removes duplicated example implementations.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
hotcell-server/lib/hot_cell/health_operations.rb |
Adds packaged health operations. |
hotcell-server/test/health_operations_test.rb |
Tests opt-in and round-trip behavior. |
examples/operations/health.rb |
Enables packaged probes in example cells. |
examples/operations/echo.rb |
Removes duplicated echo operation. |
examples/operations/reopen.rb |
Removes duplicated reopen operation. |
examples/lib/clients.rb |
Uses new operation names. |
docs/DEPLOYMENT.md |
Updates the reopen probe reference. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Echo and Reopen are the operations an application copies into its cell for health checks. bc5 and HEY have both copied them, and copies drift. They move into the server gem as health.echo and health.reopen, and a cell serves them only if it requires hot_cell/health_operations.
flavorjones
force-pushed
the
probe-operations
branch
from
September 28, 2026 15:27
646feba to
9eec5f3
Compare
Requiring it before `hot_cell/server` raised `NameError` for `HotCell::Operation`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README still told applications to copy the example files this branch deletes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Echo and Reopen are the operations an application copies into its cell for health checks. bc5 and HEY have both copied them, and copies drift. They move into the server gem as health.echo and health.reopen, and a cell serves them only if it requires hot_cell/health_operations.