Force LF line endings for Docker shell scripts - #2201
Open
danielvanza wants to merge 1 commit into
Open
danielvanza wants to merge 1 commit into
danielvanza wants to merge 1 commit into
Conversation
danielvanza
marked this pull request as ready for review
September 19, 2026 14:50
Contributor
Author
|
Quick heads up that the workflows on this one are pending approval, so nothing has run yet. Once they're approved I'll keep an eye on the results. This just pins the three Docker shell scripts to LF to close out #198. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
text eol=lfrules fordocker-entrypoint.sh,process-environment.sh, andsetup-ssl.shso Windows checkouts cannot produce CRLF and break the container entrypoint.Validation
git check-attr eol text -- docker-entrypoint.sh process-environment.sh setup-ssl.sh— each file reportstext: set,eol: lf.git -c core.autocrlf=true clone --branch main(pre-fix) yieldswith CRLF line terminators(25 CRs indocker-entrypoint.sh); the same clone ofshell-scripts-lfyieldsASCII text(0 CRs).docker build -t graph-explorer .→ success;docker run -p 8080:80 ... graph-explorer+curl http://localhost:8080/status→OK(HTTP 200); container log showsSSL disabled. Skipping self-signed certificate generation.docker exec ge sh -c "tr -cd '\r' < /graph-explorer/docker-entrypoint.sh | wc -c"—0carriage returns.docker buildof the pre-fix clone → success, butdocker runexits 1 withexec ./docker-entrypoint.sh: no such file or directoryand/statusis unreachable.pnpm checks— passed.pnpm test— passed (222 files, 2705 tests).Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.