Skip to content

Force LF line endings for Docker shell scripts - #2201

Open
danielvanza wants to merge 1 commit into
aws:mainfrom
danielvanza:shell-scripts-lf
Open

danielvanza wants to merge 1 commit into
aws:mainfrom
danielvanza:shell-scripts-lf

Conversation

@danielvanza

Copy link
Copy Markdown
Contributor

Description

  • Add text eol=lf rules for docker-entrypoint.sh, process-environment.sh, and setup-ssl.sh so Windows checkouts cannot produce CRLF and break the container entrypoint.
  • All three files are already LF in the repository, so this prevents regressions without rewriting history.

Validation

  • git check-attr eol text -- docker-entrypoint.sh process-environment.sh setup-ssl.sh — each file reports text: set, eol: lf.
  • git -c core.autocrlf=true clone --branch main (pre-fix) yields with CRLF line terminators (25 CRs in docker-entrypoint.sh); the same clone of shell-scripts-lf yields ASCII text (0 CRs).
  • docker build -t graph-explorer . → success; docker run -p 8080:80 ... graph-explorer + curl http://localhost:8080/statusOK (HTTP 200); container log shows SSL disabled. Skipping self-signed certificate generation.
  • docker exec ge sh -c "tr -cd '\r' < /graph-explorer/docker-entrypoint.sh | wc -c"0 carriage returns.
  • CRLF-before reproduction: docker build of the pre-fix clone → success, but docker run exits 1 with exec ./docker-entrypoint.sh: no such file or directory and /status is unreachable.
  • pnpm checks — passed.
  • pnpm test — passed (222 files, 2705 tests).

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have verified pnpm checks passes with no errors.
  • I have verified pnpm test passes with no failures.
  • I have covered new added functionality with unit tests if necessary.
  • I have updated documentation if necessary.

@danielvanza

Copy link
Copy Markdown
Contributor Author

Quick heads up that the workflows on this one are pending approval, so nothing has run yet. Once they're approved I'll keep an eye on the results. This just pins the three Docker shell scripts to LF to close out #198. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] exec ./docker-entrypoint.sh: no such file or directory #85[Bug]

1 participant