Repository navigation
fix(kafka): deserialize empty string record key instead of returning None - #8698
Open
ASHMEET555 wants to merge 1 commit into
Open
ASHMEET555 wants to merge 1 commit into
ASHMEET555 wants to merge 1 commit into
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8696
Summary
Changes
ConsumerRecordRecords.key, replace truthiness checkif not key:with identity checkif key is None:. This ensures Kafka events with empty string keys ("key": "") are deserialized properly rather than treated as absent and returningNone.KafkaEventRecord.decoded_keyinaws_lambda_powertools.utilities.data_classes.kafka_event.test_kafka_consumer_default_deserializer_key_is_empty_string.User experience
"key": ""), accessingrecord.keyreturnedNone, making it indistinguishable from a null/missing key.Nonekeys returnNone. An empty string key is preserved and deserialized (returning""by default, or passed to the configured deserializer).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.