Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the direct spring-core dependency from the PDP engine, reducing the engine’s dependency footprint and avoiding the inclusion of a general-purpose framework for a small set of utility functions.
Spring utilities were replaced with lightweight internal implementations while preserving the resource-location and placeholder-resolution behavior used by the PDP:
Added ResourceLocationResolver supporting:
Added PlaceholderResolver supporting:
Preserved system-property resolution with environment-variable fallback in PdpBean.
Replaced Spring resource utility usage in PDP configuration, schema/catalog loading, static policy loading, test utilities, JSON/conformance tests, and the functional benchmark.
Removed spring-core and the now-unnecessary jcl-over-slf4j dependency from pdp-engine.
Updated Javadocs to describe the supported resource types without referring to Spring APIs.
Why
The PDP engine only used a small subset of Spring Core’s utility functionality. Keeping the full dependency increased the runtime dependency graph and exposed consumers to Spring version alignment and potential transitive dependency/security-management overhead.
The new internal utilities implement only the behavior required by AuthzForce, keeping the PDP engine framework-independent without changing its public resource-location formats.
Validation
The following checks were performed:
Full reactor build and test suite:
Dependency verification:
Source verification:
Added/extended tests covering:
Existing configuration loading, schema/catalog resolution, policy loading, CLI tests, XACML conformance tests, JSON tests, and test utilities all continue to pass.