Skip failed public key parse for HMAC string secrets - #1047
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
verify() always called createPublicKey first. For a normal HMAC string secret that throws, which dominated verify time. Try createSecretKey first for strings that are not PEM, SSH, or JWK, and keep PEM public keys on the public-key path so HS256 cannot treat them as HMAC secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct.
Description
verify() currently tries createPublicKey first for every non KeyObject secret. For a normal HMAC string secret that call always throws, and that throw dominates verify time.
String secrets that do not look like PEM, SSH, or JWK now go through createSecretKey first. PEM public keys still go through createPublicKey first, so an HS256 token cannot treat an RSA public key as an HMAC secret.
References
Fixes #1046
Testing