Repository navigation
Open the path and known-destination stores on nodes without transport enabled - #98
Closed
jamiecounsell wants to merge 1 commit into
Closed
jamiecounsell wants to merge 1 commit into
jamiecounsell wants to merge 1 commit into
Conversation
… enabled With RNS_USE_FS, the path table and known destinations are backed by the path, known-destination and hashlist stores, but Transport::start() only opened those stores when transport was enabled. As a result, a leaf node couldn't record a path or remember an announce. Leaf nodes still need to remember announces, so the stores now open on every node, like the Python reference. Everything else in that block (tunnel table, probe destination) remains transport-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rUgoKJdB4U8fNS9HybY8S
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
RNS_USE_FS, the path table and known destinations are backed by the path, known-destination and hashlist stores, butTransport::start()only opens those stores when transport was enabled. As a result, a leaf node couldn't record a path or remember an announce.But leaf nodes still need to remember announces :D so this opens the stores on every node (like the Python reference). Everything else in that block (tunnel table, probe destination) remains transport-only.
Testing: running in SolarOS on a ThinkNode M9 (ESP32-S3, ESP-IDF) against Python RNS nodes over LoRa, exchanging LXMF messages. Native tests pass, and the series builds for
ttgo-lora32-v21andwiscore_rak4631.