Repository navigation
Conversation
The "Paths Unresponsive" metric (field PathsUnresponsive) returned Transport::paths_responsive() and "Paths Responsive" returned Transport::paths_unresponsive(), so remote management showed each counter under the other's name. Return the matching counter for each field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the built-in
Infoprovisioning namespace, the two path responsiveness metrics read each other's counter (src/microReticulum/Provisioning/BuiltinNamespaces.cpp, currentmaster40fa628):Transport::mark_path_unresponsive()increments_paths_unresponsiveandmark_path_responsive()increments_paths_responsive, so anyone reading these metrics over remote management (field ids 10 and 11) sees the number of unresponsive paths reported as responsive and vice versa.Change
Each field now returns its own counter. Two lines, no change to field ids, names or wire format.
Testing
native(Ubuntu 24.04, GCC 13.3, PlatformIO 6.2.0)pio test -e native: 182/182 passedttgo-t-beam(ESP32)wiscore_rak4631(nRF52840)There is no existing test for the built-in metrics. A unit test for this would need a populated path table to drive
mark_path_responsive(), which seemed out of proportion for a two-line fix; happy to add one if you prefer.Found while reading the code for #95.
🤖 Generated with Claude Code