Repository navigation
Reporting managers who can approve their reports' days off - #114
Merged
Merged
Conversation
… them decide days off Each person can have a reporting manager on a standup, picked from the people who manage a standup. On a standup that needs approval, their day-off requests also go to that reporting manager, who can approve or decline them in Chat, the web app or the API. Working requests, and standups on self-service or managers only, are unchanged. The say ends once the reporting manager no longer manages any standup. Migration 22 adds the reporting manager to participants, with an index. Co-authored-by: shrey-CDZ <279933707+shrey-CDZ@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Spec:
specs/009-reporting-managers.mdThis carries forward the proposal in #113 by @shrey-CDZ, with the review's fixes.
Each person can have a reporting manager on a standup, picked from the people who manage a standup. On a standup that needs approval, their day-off requests also go to that reporting manager. The reporting manager can approve or decline them in Chat, the web app or the API, without managing the standup.
Changes
participants.reporting_managerandreporting_manager_name, with an index (SQLite and Postgres). It is per standup because it lives on the roster row.PATCH /standups/:id/participants/:userNametakesreportingManager, which must be a manager and not the person themselves;nullclears it. Participants returnreportingManagerandreportingManagerName. NewGET /standups/:id/manager-candidates.GET /requestsand approve/decline admit a reporting manager.Checks
bun run typecheck && bun run test:coveragepass (100% lines and functions)bun run web:typecheck && bun run web:testpasstests/reporting-managers.test.ts, plus web tests for the picker)docs/guide/) updated for anything people will notice, andbun run docs:buildpassessite/) updated if a feature it describes changed, andbun run site:buildpasses (no change needed)