Repository navigation
Polls with questions and a deadline - #112
Merged
Merged
Conversation
…nd, docs and site
Bun 1.4.4 reports existing catch blocks as uncovered on Linux, which fails the coverage gate on main. CI now reads the version from .bun-version, so upgrades are deliberate.
express 5.3.0 is the latest release and accepts body-parser ^2.3.0, so only the lockfile changes. body-parser 2.4.0 needs qs ^6.16.1, which moves qs to 6.17.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Spec:
specs/008-question-polls.mdManagers can send a one-time poll to a standup's roster: up to 10 questions of short text, long text, dropdown, single choice or multiple choice, with a close time. People answer in a Chat form from a DM card, get one reminder before the close, and can change their answers until it closes. Results are posted in the space when it closes and kept in the web app.
Changes
question_pollsandquestion_poll_people(SQLite and Postgres). Deleting a standup or its history removes its polls.QuestionPollsservice: draft checks, sending (people on vacation are skipped), answers, reminder, close (on time or early), results and CSV export. The scheduler tick drives the reminder, count refresh and close, so restarts don't repeat or skip work.pollscommand also lists open polls with questions.list_question_pollsandget_question_poll_results. Webhook:poll_closed.standups.configure), and to the people asked once an everyone-sees poll closes. Members holdanswers.view, so that permission isn't enough. Anonymous polls never return names. CSV export guards against spreadsheet formulas..bun-version. Bun 1.4.4 reports existing catch blocks as uncovered on Linux, which fails the coverage gate onmaintoo.Checks
bun run typecheck && bun run test:coveragepass (100% lines and functions)bun run web:typecheck && bun run web:testpassdocs/guide/) updated for anything people will notice, andbun run docs:buildpassessite/) updated if a feature it describes changed, andbun run site:buildpasses