Repository navigation
Make standup days a default, and set people's days per standup - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Spec:
specs/007-standup-days-default.mdA standup's days were a hard limit: someone who works Wednesday to Sunday couldn't be prompted at the weekend unless the whole standup ran seven days. And a person's days were one week shared by every standup they're on. Now the standup's days are the default, anyone can be given any days, and a person's days belong to one standup.
Changes
workingday). Nobody else is prompted, listed as away or counted.run nowstill treats the day as a standup day. The weekly digest still posts after the standup's last default day.ScheduleService.setWorkingDaystakes a standup and judges that standup's policy and managers only. Replies, the DM to the person, the managers' digest and theschedule_changewebhook name the one standup. Today's run is re-evaluated in that standup's own timezone.days @person …in a space changes that standup. In a DM, someone on several standups is asked which, withdays #id …for each.PATCH /me/schedule,PATCH /people/:userName/scheduleandset_working_daystake optionalstandupId. The schedule view addsstandups(per-standup days). WithoutstandupIdevery standup changes, as before, documented as deprecated, as is the top-levelworkingDays. Someone else's schedule lists only the standups the caller manages. The Team list says "Varies by standup".participants.working_dayswas already per standup.Checks
bun run typecheck && bun run test:coveragepass (100% lines and functions)bun run web:typecheck && bun run web:testpasstests/standup-days.test.ts,tests/api-schedule.test.ts,tests/mcp.test.ts,web/src/lib/roster.test.tsx,web/src/pages/schedule.test.tsx)docs/guide/) updated for anything people will notice, andbun run docs:buildpassessite/) updated if a feature it describes changed, andbun run site:buildpasses (no change needed)