Repository navigation
Clear the open code-scanning alerts - #108
Merged
Merged
Conversation
Remove two unused test variables, and strip line breaks from logged auth failure reasons with an explicit replace that CodeQL recognises. The existing control-character replace already did this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Bug fix, no spec. Clears the three open code-scanning alerts.
Changes
standupintests/scheduler.test.tsand an unusedcallsinweb/src/pages/standup/tabs.test.tsx.src/server.ts):logSafealready replaced every control character, newlines included, but CodeQL doesn't recognise a\p{Cc}replace as cleaning. It now strips\rand\nwith an explicit replace first. Behaviour is unchanged; the existing test that a rejected request logs no raw newline still passes.Checks
bun run typecheck && bun run test:coveragepass (100% lines and functions)bun run web:typecheck && bun run web:testpassdocs/guide/) updated for anything people will notice, andbun run docs:buildpasses (nothing to update)site/) updated if a feature it describes changed, andbun run site:buildpasses (nothing to update)