Repository navigation
Make the SMTP connect timeout configurable - #38
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
GenericProviderClienttakes an optional last constructor argument,int $connectTimeout, and passes it toSMTP::connect().check()used to callconnect($mxServer)with no timeout, so PHPMailer's default of 30 s applied.GenericProviderClient::DEFAULT_CONNECT_TIMEOUT(30), which keeps today's behaviour, so this is a minor release (v2.12.0). A consumer whose MX servers are unreachable can now fail fast instead of waiting 30 s per server.createConnection()method, so a test can substitute a recordingSMTP. That is whatGenericProviderClientTestdoes to pin both the default and a configured timeout.Test plan
Shipping
Merging this PR ships nothing: it needs a semver tag / GitHub release (v2.12.0), then a
composer require assoconnect/php-smtp-toolbox:^2.12bump PR in the consumer. Two reviews total.🤖 Generated with Claude Code