Repository navigation
[IT9PE1-32062] Keep accepting request URLs without a TLD - #45
Conversation
487e21b to
17bc936
Compare
|
❌ The last analysis has failed. |
|
|
🤖 Review gate — 0 error / 0 warning / 2 info Human review needed: yes — stacked on #44, so it cannot be merged before it. On its own the agent found nothing to flag: 🧪 Coverage: 1/1 behavior changes covered — discriminates on the |
Symfony 7.1 deprecates omitting the requireTld option of the Url constraint, and Symfony 8 flips its default to true. Log::$requestUrl would then reject URLs such as http://localhost/..., so the current behaviour is now spelled out. Refs IT9PE1-32062 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
symfony/validator is only a dev requirement, and symfony/framework-bundle 7.4 still accepts validator 6.4. A consumer on validator 7.0 would get an unknown named argument error from #[Assert\Url(requireTld: false)]. Refs IT9PE1-32062 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bf9fd15 to
2813b23
Compare
|
🤖 Review gate — re-run after #44 was merged, supersedes the previous verdict — 0 error / 0 warning / 2 info Human review needed: no — no longer stacked: rebased on 🧪 Coverage: 1/1 behavior changes covered — |
|



Summary
Refs IT9PE1-32062
requireTld: falseexplicitly on theUrlconstraint ofLog::$requestUrl. Omitting it is deprecated since Symfony 7.1, and Symfony 8 flips the default totrue: request URLs without a TLD (http://localhost/...) would then fail validation.falseis the current default, so nothing changes on Symfony 7. On Symfony 8 it keeps today's behaviour.conflict: symfony/validator <7.4: validator is only a dev requirement and symfony/framework-bundle 7.4 still accepts validator 6.4, so a consumer on validator 7.0 would otherwise hit an unknown named argument error.Test plan
LogTest::testRequestUrlWithoutTldIsValidvalidates alocalhostURL. Without the fix it fails on the highest dependency set (symfony/validator 8.1.8, checked locally).Shipping
Merging this PR ships nothing: it needs a semver tag / GitHub release, then a
composer require assoconnect/log-bundle:^x.ybump PR in the backend. Two reviews total. A minor release (v2.7.0) covers #44 (merged) and this PR.🤖 Generated with Claude Code