Skip to content

feat(run--watch): only restart when runfiles change - #1511

Merged
thesayyn merged 1 commit into
mainfrom
restart-mode-changedetector
Sep 29, 2026
Merged

thesayyn merged 1 commit into
mainfrom
restart-mode-changedetector

Conversation

@jbedard

@jbedard jbedard commented Sep 26, 2026

Copy link
Copy Markdown
Member

Properly detect when runfiles changes have occurred when doing a rebuild on a run --watch target and if we must update the running target or noop

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; 🤖

@jbedard
jbedard requested a review from thesayyn September 26, 2026 02:17
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bc211f4d-4fa3-487c-b6c3-e7133d94ee73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aspect-workflows

aspect-workflows Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Aspect Workflows Tasks

📅 Mon Sep 28 02:40:28 UTC 2026

Task Results

Reproduce

❌ delivery (delivery-uncacheable · delivery-gha-debug · delivery-dry-run · delivery-dry-run-build · delivery-gha)

# --mode=always --track-state=false for off-runner with no state backend.
aspect delivery \
  --commit-sha=ae7404025675a6f5efad8c8f97d7c05bd93b5773 \
  --mode=always \
  --track-state=false \
  --dry-run=true

Install aspect: aspect.build/docs/cli/install


⏱ Last updated Mon Sep 28 02:48:48 UTC 2026 · 📊 GitHub API quota 788/7,700 (10% used, resets in 26m)
🚀 Powered by Aspect CLI (v0.0.0-dev)  |  Aspect Build · X · LinkedIn · YouTube

@jbedard
jbedard force-pushed the restart-mode-changedetector branch 8 times, most recently from 728c583 to fd8398b Compare September 28, 2026 02:07
@jbedard
jbedard marked this pull request as ready for review September 28, 2026 02:21
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@jbedard
jbedard force-pushed the restart-mode-changedetector branch from fd8398b to ae74040 Compare September 28, 2026 02:33

@thesayyn thesayyn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much much better!

@thesayyn
thesayyn merged commit d0fbebd into main Sep 29, 2026
76 checks passed
@thesayyn
thesayyn deleted the restart-mode-changedetector branch September 29, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants