fix(mcp): re-check type-override rationales on every version-1 request [roadmap:deterministic-substrate] - #499
Merged
Merged
Conversation
…t [roadmap:deterministic-substrate] Implements decisions/roadmaps/deterministic-substrate.md (Tranche C). A type override's rationale may resolve outside the captured version-1 snapshot (the root's whole working tree), so the warm path, which skips recomposition while the generation is unchanged, kept serving after that Decision was retired. While any type override is applied the tracker now recomposes each request, as the version-2 tracker always does.
…deterministic-substrate] Implements decisions/roadmaps/deterministic-substrate.md (Tranche C). A version-1 server whose type override cites a Decision in docs/, outside the served decisions/ root, fails the next cached request once that Decision is retired.
…istic-substrate] Implements decisions/roadmaps/deterministic-substrate.md (Tranche C).
tcballard
force-pushed
the
claude/rationale-freshness
branch
from
September 25, 2026 13:31
6d14fa7 to
2d24108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This closes the known limitation recorded in #495.
A type override's rationale Decision may resolve outside the captured version-1 snapshot: #495 made root-owned rationales resolve across the root's whole working tree. The version-1
FederatedCacheTrackerwarm path skips recomposition while the captured generation is unchanged. As a result, a cacheddecided-mcpkept serving after that Decision was retired, while a fresh process correctly failed withcorpus-federation-invalid-override.While any type override is applied, the version-1 tracker now recomposes on every request, which is what the version-2 tracker already does for every request. Corpora without type overrides keep the warm path unchanged.
Version 2 had no gap:
GraphFederatedCacheTracker::read_or_recomposerunscompose_verified_federation, including the rationale check, on every request.Roadmap / ADR Trace
decisions/roadmaps/deterministic-substrate.md(Tranche C)Scope
rust/rac-engine/src/derived_cache.rs: one condition on the v1 warm path.rust/decided-mcp/tests/spec_registry_freshness.rs: regression test.docs/validation.md,CHANGELOG.md.Product / Architecture Decisions
User-Facing Contract
corpus-federation-invalid-override … not a live Decision) instead of being noticed only after a restart.Verification
cargo fmt --check;cargo clippy --workspace --release --no-deps -- -D warningsand--all-targets: clean;cargo test --workspace --release: pass.get_summarysucceeds (the stale model is served), so the test fails.Review Path
derived_cache.rs(8 lines).Notes For Reviewer
Implementation Process
Implemented with AI assistance under the roadmap contract; final scope, review, and acceptance decisions were made by the maintainer.