Repository navigation
feat(notifications): public host for Pusher-protocol servers - #14
Merged
Merged
Conversation
…elated documentation
… to include `realtime.push` setting and Pusher options
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PusherRealtimeDriver.clientConfig()gave browsers the samehost/port/ TLS the server uses to reach Pusher. That breaks when the two differ, such as soketi inside Docker (soketi:6001for the API,localhost:6001for the browser) or soketi behind a TLS proxy.Added
transports.pusher.public_host,public_portandpublic_use_tls(envPUSHER_PUBLIC_HOST,PUSHER_PUBLIC_PORT,PUSHER_PUBLIC_USE_TLS).wsHost/wsPort/forceTLSthatclientConfig()hands to clients. Each defaults to its server-side counterpart, so existing setups are unchanged.Templates
realtime.push(REALTIME_PUSH).host/portlines were dropped from the Express template, so the templates stay lean.Test plan
PUSHER_PUBLIC_*env.pnpm lint,pnpm build,pnpm docs:build; template typechecks cleanvitest run: 583 passed, 5 skipped