Repository navigation
[APTLSB-1369] fix: stop applying meta defaultValue in cells, forms and modals - #120
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditableTableCell,FieldDisplay) render exactly what the backend returns. A null or empty value stays an empty cell.getFieldDefaultValueinfieldUtils.tsandstandardFieldUtils.tsnow returns only the type's empty value (false,0,[]or'').It no longer reads
meta.defaultValueor the per-type*Defaultkeys.This affects the create and edit record modals and the form view.
Why
Column defaults are now applied by the database. The frontend prefilling or displaying
meta.defaultValuemade null cells look like they held a value.
Not changed
The field-settings UI still writes
defaultValueintometa, since that is how the value reaches the backend.Tests
Updated the tests that asserted the old fallback. The full suite passes.