Repository navigation
Add internal gateway cert SANs only for ca issuer - #1381
Merged
Merged
Conversation
ACME issuers reject cluster-internal names like prom-label-proxy and otel-nats.<ns>.svc, which fails the whole order and leaves the gateway HelmRelease waiting on a Certificate that never becomes Ready. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Oct 29, 2026
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
service-gateway's<tenant>-gwCertificate always included cluster-internal SANs (prom-label-proxy*,otel-nats*,*.otel-nats*,otel-forwarder*), whateverinfra.tls.issuerwas set to.With
issuer: letsencrypt(orletsencrypt-staging), the ACME server rejects the entire order:The Certificate then never becomes Ready, so the gateway HelmRelease hangs in
Running 'upgrade' actionuntil it times out, and retries forever because remediation retries are-1. That in turn blockskubeops/ace(dependsOngateway) and the ace-upgrader job.This change adds the internal SANs only when
infra.tls.issuerisca.Rendered
dnsNameswithhostType=domain:letsencrypt:ops.appscode.devonlyca: unchanged (public host + all internal SANs)