Repository navigation
Order uninstall-ace.sh releases by dependsOn and keep Flux - #1379
Merged
Merged
Conversation
- Delete HRs in reverse spec.dependsOn waves, so OCM addon managers go before the hub and kube-prometheus-stack before monitoring-operator; stash-presets waits for kubestash via an extra edge. - Run the OCM hub teardown right before the cluster-manager-hub wave. - Select HRs by release-name annotation or the part-of label, so HRs created outside the charts (e.g. akp-crd-manager by b3) are removed. - Keep Flux: suspend and delete the flux2 HR without uninstalling it. - Detect the flux controllers' namespace instead of assuming flux-system. - Require kubectl, helm and jq up front. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Oct 29, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec.dependsOnwaves, so OCM addon managers go before the hub and kube-prometheus-stack before monitoring-operator;stash-presetswaits forkubestashvia an extra edge (its HR has nodependsOn).cluster-manager-hubwave.app.kubernetes.io/part-oflabel, so HRs created outside the charts (e.g.akp-crd-managerby b3) are removed.flux2HR, so helm-controller doesn't uninstall Flux while other HRs are still being torn down.flux-system.kubectl,helmandjqup front.