Repository navigation
K2GO-269 style(settings): match top-level tab title convention - #713
Merged
Merged
Conversation
Settings tab title used HeadlineSmall with off-grid padding; the other bottom-nav tabs (Library/Connect/Clone) use HeadlineMedium + k2go_ink. Align it: HeadlineSmall -> HeadlineMedium, padding 14/6 -> 16/8 (4dp grid).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings tab title now matches the top-level tab title convention used by the
other tabs (Connect, Dashboard): textAppearanceHeadlineMedium and 16dp/8dp
top/bottom padding on the 4dp grid.
Before it was the only top-level tab a step smaller (HeadlineSmall) and off
the grid (14dp/6dp), so it read as inconsistent next to the sibling tabs.
Change (fragment_k2go_settings.xml, title TextView):
UI changes
so the change is theme-independent. Light and dark render the same title in a
larger scale.
References K2GO-269 (light UX / visual-polish umbrella; this PR references it,
not a child, per convention).