Repository navigation
Handle NULL values in SQL ORDER BY - #892
Open
AarushShetty346 wants to merge 1 commit into
Open
AarushShetty346 wants to merge 1 commit into
AarushShetty346 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #890
What changes were proposed in this pull request?
ORDER BYon a column with NULL values threw aNullPointerExceptioninSortKeyExtractor, because it calledcompareToon the null value.WayangSortVisitornow passes the null direction of each field collation toSortKeyExtractor. If it isUNSPECIFIED, it usesDirection.defaultNullDirection()(LAST for ASC, FIRST for DESC), which is Calcite's default.SortKeyExtractor.compareToplaces nulls by that direction before comparing the values.NULLS FIRST/NULLS LASTaren't flipped for DESC, so they stay absolute like in standard SQL.How was this patch tested?
I added
javaSortWithNullsAscending,javaSortWithNullsDescendingandjavaSortWithNullsFirsttoSqlToWayangRelTest. They use a new three-rowexampleNull.csvwith one emptycol1. All three fail with the NPE on main and pass with this change. The otherwayang-api-sqltests still pass (34 in total).