Repository navigation
Conversation
Column names on a table source were dropped when the operator was copied, and JDBC scans always used SELECT * because the table clause is only the FROM target. Keep the names and use them as the SELECT list when they are plain identifiers.
Author
|
@novatechflow can u kindly review this PR |
Author
|
@zkaoudi can u kindly review this |
Keep declared-column SELECT lists for table sources after JDBC sources switched to the configuration-aware SQL API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TableSource, including when the operator is copied.*.JdbcTableSource.createSqlClause()still returns only the table name, so it stays in theFROMclause (SELECT name, age FROM customer).ST_AsText(geom), still use*.WayangTableScan.fieldsis now used to choose which columns are passed to the table source.Test plan
TableSourceTest(names are kept, and a copy does not share the array)JdbcExecutorTest: declared columns, expression-style names, and a projection overriding the source columnsSELECT order_id, customer_id, region, amount FROM orders)Fixes : #648