fix(workflow): return 404 for missing workflow type

[VuMartin]

What changes were proposed in this PR?

Return 404 Not Found when the workflow type endpoint is requested for a workflow that does not exist. Previously, getWorkflowType dereferenced a null DAO result and returned 500 Internal Server Error.

Before:

After:

Any related issues, documentation, discussions?

Closes #8300

How was this PR tested?

• Ran WorkflowResourceSpec
• Verified GET /api/workflow/type/2147483647 returns 404 instead of 500
• Added regression coverage for a missing workflow type

Was this PR authored or co-authored using generative AI tooling?

Generated-by: ChatGPT (5.5 mini)

[github-actions]

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. release/* labels drive the post-merge backport, so add or remove one to change where this fix lands.

Release branch	Analysis
✅ release/v1.3	Change detected on this branch — label added; this fix is queued to backport here. Requested review from @mengw15.
✅ release/v1.2	Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7.

Auto-label run.

[github-actions]

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

• Contributors with relevant context: @yangzhang75, @aglinxinyuan
  You can notify them by mentioning @yangzhang75, @aglinxinyuan in a comment.

[github-actions]

✅ No material benchmark regressions detected

🟢 4 better · 🔴 0 worse · ⚪ 11 noise (<±5%) · 0 without baseline

Compared against main 1cbe857 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

	config	throughput	MB/s	latency	max Δ latest / 7d
🟢	bs=10 sw=10 sl=64	347	0.212	28,556/36,663/36,663 us	🟢 -49.9% / 🔴 +129.4%
⚪	bs=100 sw=10 sl=64	786	0.48	125,807/160,269/160,269 us	⚪ within ±5% / 🔴 +46.7%
⚪	bs=1000 sw=10 sl=64	902	0.55	1,109,078/1,176,898/1,176,898 us	⚪ within ±5% / 🔴 +12.9%

Baseline details

Latest main 1cbe857 from same runner

config	metric	PR	latest main	7d avg	Δ latest	Δ 7d
bs=10 sw=10 sl=64	throughput	347 tuples/sec	301 tuples/sec	755.36 tuples/sec	+15.3%	-54.1%
bs=10 sw=10 sl=64	MB/s	0.212 MB/s	0.183 MB/s	0.461 MB/s	+15.8%	-54.0%
bs=10 sw=10 sl=64	p50	28,556 us	29,670 us	12,938 us	-3.8%	+120.7%
bs=10 sw=10 sl=64	p95	36,663 us	73,135 us	15,980 us	-49.9%	+129.4%
bs=10 sw=10 sl=64	p99	36,663 us	73,135 us	19,233 us	-49.9%	+90.6%
bs=100 sw=10 sl=64	throughput	786 tuples/sec	797 tuples/sec	976.3 tuples/sec	-1.4%	-19.5%
bs=100 sw=10 sl=64	MB/s	0.48 MB/s	0.487 MB/s	0.596 MB/s	-1.4%	-19.4%
bs=100 sw=10 sl=64	p50	125,807 us	121,641 us	102,340 us	+3.4%	+22.9%
bs=100 sw=10 sl=64	p95	160,269 us	155,825 us	109,262 us	+2.9%	+46.7%
bs=100 sw=10 sl=64	p99	160,269 us	155,825 us	118,827 us	+2.9%	+34.9%
bs=1000 sw=10 sl=64	throughput	902 tuples/sec	912 tuples/sec	1,006 tuples/sec	-1.1%	-10.4%
bs=1000 sw=10 sl=64	MB/s	0.55 MB/s	0.556 MB/s	0.614 MB/s	-1.1%	-10.5%
bs=1000 sw=10 sl=64	p50	1,109,078 us	1,094,817 us	999,855 us	+1.3%	+10.9%
bs=1000 sw=10 sl=64	p95	1,176,898 us	1,137,829 us	1,042,833 us	+3.4%	+12.9%
bs=1000 sw=10 sl=64	p99	1,176,898 us	1,137,829 us	1,070,722 us	+3.4%	+9.9%

Raw CSV

config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,575.97,200,128000,347,0.212,28556.31,36663.44,36663.44
1,100,10,64,20,2543.65,2000,1280000,786,0.480,125806.99,160269.09,160269.09
2,1000,10,64,20,22183.10,20000,12800000,902,0.550,1109078.07,1176898.05,1176898.05

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.06%. Comparing base (1cbe857) to head (3608088).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8398      +/-   ##
============================================
+ Coverage     94.03%   94.06%   +0.03%     
- Complexity     4821     4926     +105     
============================================
  Files          1204     1208       +4     
  Lines         48991    49795     +804     
  Branches       5956     6066     +110     
============================================
+ Hits          46067    46839     +772     
- Misses         1458     1479      +21     
- Partials       1466     1477      +11     

Flag	Coverage Δ		*Carryforward flag
access-control-service	81.00% <ø> (ø)		Carriedforward from 1cbe857
agent-service	99.32% <ø> (ø)		Carriedforward from 1cbe857
amber	90.18% <100.00%> (+0.26%)	⬆️
computing-unit-managing-service	73.67% <ø> (ø)		Carriedforward from 1cbe857
config-service	87.12% <ø> (ø)		Carriedforward from 1cbe857
file-service	87.91% <ø> (ø)		Carriedforward from 1cbe857
frontend	96.79% <ø> (ø)		Carriedforward from 1cbe857
notebook-migration-service	83.57% <ø> (ø)		Carriedforward from 1cbe857
pyamber	98.47% <ø> (ø)		Carriedforward from 1cbe857
workflow-compiling-service	77.19% <ø> (ø)		Carriedforward from 1cbe857

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.