Skip to content

Rename the etcd configuration password env var to SW_CONFIG_ETCD_PASSWORD - #14251

Open
wu-sheng wants to merge 1 commit into
masterfrom
fix-etcd-password-env-name
Open

wu-sheng wants to merge 1 commit into
masterfrom
fix-etcd-password-env-name

Conversation

@wu-sheng

Copy link
Copy Markdown
Member

Fix the lower-case etcd configuration password environment variable

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

The etcd dynamic configuration reads its password from SW_CONFIG_ETCD_password (application.yml). It is the only lower-case environment variable in application.yml, and a user who follows the naming of every other variable and sets SW_CONFIG_ETCD_PASSWORD gets no password. #14250 made the docs match the lower-case name; this renames the variable itself.

Changes:

  • application.yml: password: ${SW_CONFIG_ETCD_PASSWORD:}.
  • dynamic-config-etcd.md and the configuration vocabulary use the new name.
  • The changelog states that the lower-case name no longer has any effect, so a deployment that sets it must switch to the new name.

No unit test: the change is a placeholder name in application.yml. No test, e2e case or Helm chart sets either spelling.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

…WORD

The etcd dynamic configuration read its password from SW_CONFIG_ETCD_password,
the only lower-case environment variable in application.yml. Rename it to
SW_CONFIG_ETCD_PASSWORD, and update the etcd configuration doc, the
configuration vocabulary and the changelog. The lower-case name no longer
has any effect.
@wu-sheng
wu-sheng requested a balanced review from Copilot November 18, 2026 13:32
@wu-sheng wu-sheng added this to the 11.2.0 milestone Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@wu-sheng
wu-sheng requested a review from wankai123 November 18, 2026 13:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants