Skip to content

Move the test BanyanDB to the TopN and time-order fixes, and run the three ITs that waited for them - #14247

Merged
wu-sheng merged 1 commit into
masterfrom
test/banyandb-topn-time-order-fixes
Nov 17, 2026
Merged

wu-sheng merged 1 commit into
masterfrom
test/banyandb-topn-time-order-fixes

Conversation

@wu-sheng

Copy link
Copy Markdown
Member

Fix #14217 and #14218 on the OAP test side: move the test BanyanDB to the fixes and run the three ITs that waited for them

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

The BanyanDB fixes. The BanyanDB storage ITs (#14216) found two BanyanDB bugs and disabled one test for each until BanyanDB fixed them. Both fixes are merged; BanyanDB 8efdf0ca carries both. This PR moves SW_BANYANDB_COMMIT in test/e2e-v2/script/env, docker/.env and benchmarks/env to that commit.

The ITs. findsTheNewestEndpointsUpToTheLimit (#14218), ranksThroughThePreBuiltTopNOfAService and ranksThroughThePreBuiltTopNOfALayer (#14217) run again.

  • On 8efdf0ca, all 188 storage-plugin ITs and all 46 BanyanDB client ITs pass.
  • On the previous pin 88245d39, these three fail:
    • findEndpoint with limit 2 returned [GET:/api/orders, POST:/api/orders] instead of the newest [GET:/api/users, POST:/api/orders].
    • Both TopN reads returned each endpoint's best window, 90, 60, 15, instead of its mean, 60, 50, 10.

What else moves with the pin. The BanyanDB commits between the two pins also bring:

Their proto changes only add messages (an internal TopN request and the transfer RPCs), so the client proto submodule stays as it is.

…three ITs that waited for them

BanyanDB 8efdf0ca carries apache/skywalking-banyandb#1479 and #1481, the
fixes for the two bugs the BanyanDB storage ITs found and disabled tests for:

- #14218: an index-mode measure ignored an explicit ORDER BY on time and
  returned its rows in index order, so findEndpoint with a limit did not
  return the newest endpoints. findsTheNewestEndpointsUpToTheLimit runs again.
- #14217: a pre-built TopN query applied AGGREGATE BY after keeping one value
  per entity, so the MEAN OAP asks for returned each entity's best value in
  the range. ranksThroughThePreBuiltTopNOfAService and
  ranksThroughThePreBuiltTopNOfALayer run again.

SW_BANYANDB_COMMIT in test/e2e-v2/script/env, docker/.env and benchmarks/env
move together.
@wu-sheng wu-sheng added test Test requirements about performance, feature or before release. bug Something isn't working and you are sure it's a bug! labels Nov 17, 2026
@wu-sheng wu-sheng added this to the 11.2.0 milestone Nov 17, 2026
@wu-sheng
wu-sheng merged commit 28fee76 into master Nov 17, 2026
490 of 494 checks passed
@wu-sheng
wu-sheng deleted the test/banyandb-topn-time-order-fixes branch November 17, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug! test Test requirements about performance, feature or before release.

Projects

None yet

2 participants