Repository navigation
Move the test BanyanDB to the TopN and time-order fixes, and run the three ITs that waited for them - #14247
Merged
Conversation
…three ITs that waited for them BanyanDB 8efdf0ca carries apache/skywalking-banyandb#1479 and #1481, the fixes for the two bugs the BanyanDB storage ITs found and disabled tests for: - #14218: an index-mode measure ignored an explicit ORDER BY on time and returned its rows in index order, so findEndpoint with a limit did not return the newest endpoints. findsTheNewestEndpointsUpToTheLimit runs again. - #14217: a pre-built TopN query applied AGGREGATE BY after keeping one value per entity, so the MEAN OAP asks for returned each entity's best value in the range. ranksThroughThePreBuiltTopNOfAService and ranksThroughThePreBuiltTopNOfALayer run again. SW_BANYANDB_COMMIT in test/e2e-v2/script/env, docker/.env and benchmarks/env move together.
wankai123
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14217 and #14218 on the OAP test side: move the test BanyanDB to the fixes and run the three ITs that waited for them
The BanyanDB fixes. The BanyanDB storage ITs (#14216) found two BanyanDB bugs and disabled one test for each until BanyanDB fixed them. Both fixes are merged; BanyanDB
8efdf0cacarries both. This PR movesSW_BANYANDB_COMMITintest/e2e-v2/script/env,docker/.envandbenchmarks/envto that commit.ORDER BYon time and returned its rows in index order. SofindEndpointwith a limit did not return the newest endpoints, and the rows of different segments were merged out of order. BanyanDB now orders by each row's own timestamp. A limited time order is answered from the_timestampindex, and a row is dropped when a newer segment holds the same series.AGGREGATE BY. So theMEANOAP asks for returned each entity's best value in the range, not its mean. BanyanDB now aggregates every stored value of an entity before it takes the top N. In a cluster, the data nodes return per-shard partials, and the liaison merges them with replicas counted once.The ITs.
findsTheNewestEndpointsUpToTheLimit(#14218),ranksThroughThePreBuiltTopNOfAServiceandranksThroughThePreBuiltTopNOfALayer(#14217) run again.8efdf0ca, all 188 storage-plugin ITs and all 46 BanyanDB client ITs pass.88245d39, these three fail:findEndpointwith limit 2 returned[GET:/api/orders, POST:/api/orders]instead of the newest[GET:/api/users, POST:/api/orders].90, 60, 15, instead of its mean,60, 50, 10.What else moves with the pin. The BanyanDB commits between the two pins also bring:
bydbctlexport and import (feat(transfer): native-format export and import of parts and indexes skywalking-banyandb#1473);Their proto changes only add messages (an internal TopN request and the transfer RPCs), so the client proto submodule stays as it is.
CHANGESlog.