Skip to content

Send the Astronomy Shop's logs to the OAP, and bump OAP, BanyanDB and Horizon - #315

Merged
wankai123 merged 1 commit into
mainfrom
otlp-trace-logs
Nov 18, 2026
Merged

wankai123 merged 1 commit into
mainfrom
otlp-trace-logs

Conversation

@wankai123

@wankai123 wankai123 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

The otlp-trace feature's collector sent the Astronomy Shop's spans to the OAP and dropped its logs (nop). The OAP now keeps the logs of the services that set service.layer=OTLP_GENERAL, through the otlp-general LAL rule (apache/skywalking#14244), and Horizon's OTLP Service layer shows them in a Logs tab (apache/skywalking-horizon-ui#223), so the collector sends the logs too.

  • deploy/platform/docker/config/opentelemetry-demo/otel-collector-config.yaml (Docker Compose) and deploy/platform/config/opentelemetry-demo/values.yaml (Kubernetes): the logs pipeline goes through resource/layer, which adds service.layer=OTLP_GENERAL and service.namespace=otel-demo where missing, to the OAP exporter the traces use. Metrics are still dropped.
  • values.yaml: OTEL_SERVICE_NAMESPACE=otel-demo on frontend-proxy. Envoy's OpenTelemetry access logger takes service.namespace from it, and the chart leaves it empty; the collector's insert keeps an empty value, so the access logs landed under a bare frontend-proxy service apart from the proxy's spans. Docker Compose already sets it.
  • Makefile.in: OAP 28fee76e (latest master, with #14244), BanyanDB 8d577edf (the newest commit with its -plugins and -plugins-carrier images; the OAP tests pin 8efdf0ca, one commit earlier), Horizon 8569273b (Change the wait time for webdriver #223). The comments above the three tags are removed.
  • docs/readme.md: the otlp-trace row says the logs go to the OAP, linked to their traces.

Checked on a local kind cluster with FEATURE_FLAGS=banyandb,single-node,otlp-trace, on OAP 381fcbd4, BanyanDB afc64759 and Horizon 00ef5249:

  • The collector's logs pipeline exports to the OAP with no failures once the OAP is up.
  • The OAP stores logs for 15 of the demo's services under OTLP_GENERAL, as otel-demo::<service>: 1,001 of 1,134 lines in 30 minutes carry a trace id. flagd, image-provider and frontend-web send none.
  • The logs of one checkout trace, looked up by its trace id, come from frontend, checkout, cart, payment, shipping, currency, quote, product-catalog and the proxy.
  • After the OTEL_SERVICE_NAMESPACE change, the proxy's access logs land under otel-demo::frontend-proxy.

The Horizon Logs tab was checked in apache/skywalking-horizon-ui#223, against OAP 381fcbd4. This PR's image tags were not run together; Docker Compose was not run.

… Horizon

The otlp-trace feature's collector dropped the demo's logs. It now sends them
to the OAP like the spans, with service.layer=OTLP_GENERAL, and the OAP keeps
them through its otlp-general LAL rule (apache/skywalking#14244). On
Kubernetes the frontend-proxy gets OTEL_SERVICE_NAMESPACE=otel-demo, so its
Envoy access logs land under otel-demo::frontend-proxy with its spans.

OAP moves to 28fee76e for that rule, BanyanDB to 8d577edf, and Horizon to
8569273b, whose OTLP Service layer has a Logs tab
(apache/skywalking-horizon-ui#223).
@wankai123
wankai123 merged commit fd333e4 into main Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant