Repository navigation
Send the Astronomy Shop's logs to the OAP, and bump OAP, BanyanDB and Horizon - #315
Merged
Merged
Conversation
… Horizon The otlp-trace feature's collector dropped the demo's logs. It now sends them to the OAP like the spans, with service.layer=OTLP_GENERAL, and the OAP keeps them through its otlp-general LAL rule (apache/skywalking#14244). On Kubernetes the frontend-proxy gets OTEL_SERVICE_NAMESPACE=otel-demo, so its Envoy access logs land under otel-demo::frontend-proxy with its spans. OAP moves to 28fee76e for that rule, BanyanDB to 8d577edf, and Horizon to 8569273b, whose OTLP Service layer has a Logs tab (apache/skywalking-horizon-ui#223).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
otlp-tracefeature's collector sent the Astronomy Shop's spans to the OAP and dropped its logs (nop). The OAP now keeps the logs of the services that setservice.layer=OTLP_GENERAL, through theotlp-generalLAL rule (apache/skywalking#14244), and Horizon's OTLP Service layer shows them in a Logs tab (apache/skywalking-horizon-ui#223), so the collector sends the logs too.deploy/platform/docker/config/opentelemetry-demo/otel-collector-config.yaml(Docker Compose) anddeploy/platform/config/opentelemetry-demo/values.yaml(Kubernetes): thelogspipeline goes throughresource/layer, which addsservice.layer=OTLP_GENERALandservice.namespace=otel-demowhere missing, to the OAP exporter the traces use. Metrics are still dropped.values.yaml:OTEL_SERVICE_NAMESPACE=otel-demoonfrontend-proxy. Envoy's OpenTelemetry access logger takesservice.namespacefrom it, and the chart leaves it empty; the collector'sinsertkeeps an empty value, so the access logs landed under a barefrontend-proxyservice apart from the proxy's spans. Docker Compose already sets it.Makefile.in: OAP28fee76e(latest master, with #14244), BanyanDB8d577edf(the newest commit with its-pluginsand-plugins-carrierimages; the OAP tests pin8efdf0ca, one commit earlier), Horizon8569273b(Change the wait time for webdriver #223). The comments above the three tags are removed.docs/readme.md: theotlp-tracerow says the logs go to the OAP, linked to their traces.Checked on a local kind cluster with
FEATURE_FLAGS=banyandb,single-node,otlp-trace, on OAP381fcbd4, BanyanDBafc64759and Horizon00ef5249:OTLP_GENERAL, asotel-demo::<service>: 1,001 of 1,134 lines in 30 minutes carry a trace id. flagd, image-provider and frontend-web send none.OTEL_SERVICE_NAMESPACEchange, the proxy's access logs land underotel-demo::frontend-proxy.The Horizon Logs tab was checked in apache/skywalking-horizon-ui#223, against OAP
381fcbd4. This PR's image tags were not run together; Docker Compose was not run.