[core] Fix snapshot expiration for chain table delta commits - #9611
Open
huyuanfeng2018 wants to merge 4 commits into
Open
[core] Fix snapshot expiration for chain table delta commits#9611huyuanfeng2018 wants to merge 4 commits into
huyuanfeng2018 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #9595.
For Chain Tables,
ChainTablePartitionExpiremay delete expired partitions from the Snapshot branch during a Delta commit, creating a new Snapshot-branch metadata snapshot.However, automatic snapshot expiration currently only runs for the committing Delta branch. As a result, old Snapshot-branch snapshots may remain and continue referencing expired files.
Changes
When the current branch is the configured Chain Table Delta branch, also expire snapshots on the configured Snapshot branch after the normal Delta-branch expiration.
The maintenance order remains:
Tests
Added a regression test covering:
Delta commit -> ChainTablePartitionExpire -> Snapshot partition deletion -> new Snapshot metadata snapshot -> Snapshot snapshot expirationThe test verifies that expired Snapshot partitions are removed and only the latest Snapshot-branch snapshot is retained.