[core] Fall back to renaming when multipart upload is unavailable - #9610
Open
Zouxxyy wants to merge 1 commit into
Open
[core] Fall back to renaming when multipart upload is unavailable#9610Zouxxyy wants to merge 1 commit into
Zouxxyy wants to merge 1 commit into
Conversation
Jindo returns null from getMpuStore for filesystems without multipart-upload capability, such as OSS-HDFS. This caused two-phase writes to fail when the multipart stream dereferenced the missing store. Use FileIO’s rename-based two-phase stream in that case. Pass the already resolved store on the MPU path to avoid repeating Jindo’s native capability probe. Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Jindo returns
nullfromgetMpuStorewhen the filesystem does not support multipart uploads, such as OSS-HDFS. The existing two-phase write path then dereferences the missing store.Fall back to FileIO's rename-based two-phase output stream when MPU is unavailable. Filesystems supporting MPU continue using the multipart path with the already resolved store.
Tests
mvn -pl paimon-filesystems/paimon-jindo -Pspark3 spotless:applymvn -pl paimon-filesystems/paimon-jindo -am -Pspark3,fast-build -DfailIfNoTests=false -DwildcardSuites=none -Dtest=JindoFileIOTest test