download.md: build SHA-512/signature links from checksum-root - #186
Open
arnavsharma990 wants to merge 1 commit into
Open
arnavsharma990 wants to merge 1 commit into
arnavsharma990 wants to merge 1 commit into
Conversation
SHA-512 and Signature columns used release.artifact-root, so they pointed at the mirror selector (dyn/closer.lua) and returned an HTML mirror-selection page instead of the file. Every release file defines checksum-root for exactly this purpose, but no template read it. Build hash/signature hrefs from release.checksum-root and keep the Archive column on release.artifact-root. Archive rows where both roots are identical (9.0.0, 9.1.0, 10.0.0) are unaffected. Fixes apache#185 Signed-off-by: arnavsharma990 <2006arnavsharma@gmail.com>
xiaoxiang781216
approved these changes
Sep 23, 2026
xiaoxiang781216
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SHA-512 and Signature columns on the download page were built from
release.artifact-root, so for every mirror-served release they pointed at thedyn/closer.luamirror selector and returned an HTML mirror-selection page instead of the file. Every release file already defineschecksum-rootfor exactly this purpose, but no template read it. This PR switches the two columns torelease.checksum-rootand leaves the Archive column onrelease.artifact-root.Fixes #185.
Changes
download.md:51-52:.sha512/.aschrefs now use{{release.checksum-root}}instead of{{release.artifact-root}}. Two lines, no other page changes.Verification
curlbefore:.../dyn/closer.lua/nuttx/12.12.0/apache-nuttx-12.12.0.tar.gz.sha512→200 text/html, ~21 KB mirror-picker page.curlafter (canonical form now generated):https://downloads.apache.org/nuttx/12.12.0/apache-nuttx-12.12.0.tar.gz.sha512→200 text/plain, 158 bytes (the hash);.asc→200 text/plain, 833-byte PGP signature.checksum-root(e.g..../incubator/nuttx/10.1.0/...,.../nuttx/13.0.1/...).checksum-root == artifact-root, so their links are byte-identical before/after — no special handling needed. Legacy non-Apache table untouched (no hash/signature columns).Backwards compatibility
Link targets change from mirror-picker pages to canonical files; the old closer.lua URLs remain valid for anyone who bookmarked them. No permalink, collection, or deployment changes.