Add audit hooks for inter-node user data transfers - #18569
Merged
Conversation
HTHou
commented
Sep 2, 2026
HTHou
left a comment
Contributor
Author
There was a problem hiding this comment.
Main findings are inline. Please also add behavior-level tests that capture emitted events for success, remote-status failure, exception/retry, and source/destination direction, plus tests proving that a throwing audit handler never changes the transfer outcome and that audit-log writes do not recursively generate USER_DATA_TRANSFER events. The current tests only cover the event value object and the PlanNode classifier.
HTHou
commented
Sep 2, 2026
Contributor
Author
|
Addressed the latest audit review feedback in 85ff1e2:
Validation passed: focused consensus/DataNode tests (10 tests), full English reactor |
…ta-transfer # Conflicts: # iotdb-core/node-commons/src/main/i18n/en/org/apache/iotdb/commons/i18n/CommonMessages.java # iotdb-core/node-commons/src/main/i18n/zh/org/apache/iotdb/commons/i18n/CommonMessages.java
HTHou
marked this pull request as ready for review
September 2, 2026 10:05
jt2594838
reviewed
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add sender-side audit hooks for inter-node user-data transfers required by the FDP_ITT.1 audit requirements from GB/T 20273-2019.
This PR only adds audit event modeling, audit hooks, and routing through the existing audit logger. It does not introduce a new audit sink, persistence mechanism, protection mechanism, or policy implementation.
Audit record
Each transfer attempt records only:
The event is routed as
AuditEventType.USER_DATA_TRANSFER. Payload contents are never retained.Instrumented transfer paths
Review follow-ups
Explicitly out of scope
This PR has:
Verification
mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/consensus,iotdb-core/datanodemvn test-compile -DskipTestsmvn test-compile -DskipTests -P with-zh-localegit diff --checkAll commands above pass locally.