benchmark: add metrics evaluator benchmark - #831
Conversation
| return values; | ||
| } | ||
|
|
||
| std::shared_ptr<Expression> MakeExpression(ExpressionCase expression_case) { |
There was a problem hiding this comment.
Could you rebase? It seems include-cleaner has been removed, so this warning should be gone.
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Summary
This adds a focused benchmark for metrics evaluator performance now that the shared benchmark build scaffolding has landed. The benchmark covers evaluator construction separately from data-file evaluation so reviewers can see setup cost and per-file filtering cost independently.
InclusiveMetricsEvaluatorandStrictMetricsEvaluator.DataFileobjects.Part of #690.
Test Plan
git diff --check origin/main..HEAD-DICEBERG_BUILD_BENCHMARKS=ONcmake --build build-bench-ci --target metrics_evaluator_benchmarkbuild-bench-ci/src/iceberg/benchmark/metrics_evaluator_benchmark --benchmark_filter=BM_InclusiveMetricsEvaluatorMake/equal_id --benchmark_min_time=0.01scmake --build buildctest --test-dir build --output-on-failuremesonis not installed on this machine.Verification Commands
cmake -S . -B build-bench-ci -G Ninja \ -DICEBERG_BUILD_BENCHMARKS=ON cmake --build build-bench-ci --target metrics_evaluator_benchmark build-bench-ci/src/iceberg/benchmark/metrics_evaluator_benchmark \ --benchmark_filter=BM_InclusiveMetricsEvaluatorMake/equal_id \ --benchmark_min_time=0.01s cmake --build build ctest --test-dir build --output-on-failure