Repository navigation
Turn the plugin page template into a template that matches the transform and action pages. #8979 - #8980
Merged
Conversation
…orm and action pages. apache#8979
Contributor
|
Thanks @Adalennis, this makes the template usable as is. I checked the attributes, title, first rows and comments against the existing transform and action pages, the description check in the docs PR build and the hop-website README; it all matches. Not rendered, since the template isn't published. One small suggestion: for a transform, the copy instructions could also mention adding the page to the list in LGTM otherwise. |
bamaer
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8979
Rewrites
templates/template-plugin.adoc(the starting point for plugin pages, according to the developer manual's "Writing documentation" page) so it can be copied as is:documentationUrlrelates to the page.:documentationPath:,:language:,:description:(required by the docs PR build since Fail the docs PR build when a page has no description. #2606 #8957),:page-engines:for transforms only, with the meaning of yes / no / maybe / native, and:page-marketplace:for marketplace plugins only.All of it follows what the 276 transform pages and 84 action pages have in common. One template is kept rather than two, so the reference from the developer manual still holds.
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.