Repository navigation
Conversation
Contributor
|
Thanks @gvdutra, this fixes the case from #8934. I built the PR and ran the git plugin tests: all 324 pass, and both new tests fail on main. Should fix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8934.
Use the current branch's configured upstream when pulling instead of assuming that the remote branch has the same name. The existing
origin/<local-branch>fallback remains available for branches without upstream configuration.Pulling a branch with no configured upstream and no matching branch on origin now reports a clear error instead of failing with a
NullPointerException.Tests:
./mvnw -pl plugins/misc/git test(234 standard tests and 90 UI tests)./mvnw -pl plugins/misc/git spotless:apply spotless:checkmvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on this pull request automatically.