Repository navigation
build: skip Maven deploy for fesod-benchmark - #1229
Merged
bengbengbalabalabeng merged 1 commit intoOct 16, 2026
Merged
Conversation
fesod-benchmark is an internal JMH module and not a published artifact. Since it was added to the reactor (PR apache#575), the release command 'mvn clean deploy -Papache-release' would upload it to the ASF staging repository: a thin jar plus the shade-rewritten dependency-reduced pom with all compile/runtime dependencies stripped, which would publish a broken artifact to Maven Central. Set maven.deploy.skip=true so the module still builds and installs locally (benchmark CI unaffected) but is excluded from deployment. Signed-off-by: gongzhongqiang <gongzhongqiang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fesod-benchmarkmust not be published to Maven Central. Since it joined the reactor in #575 (after the 2.1.0-incubating release), the next release following the documented steps would deploy it.What's changed?
Added
maven.deploy.skip=truetofesod-benchmark/pom.xml.The release guide runs
mvn clean deploy -Papache-release -DskipTests -Dgpg.skip=falseover the full reactor. I verified the current behavior onmain(2e606a5) with the same command redirected to a localfile://repository:fesod-benchmark(pom + jar + sources jar).benchmarks.jaruberjar stays local (finalNamedoes not replace the main artifact).dependency-reduced-pom, which strips all compile/runtime dependencies (fesod-sheet,jmh-core, POI, slf4j). Publishing it would put a broken, unusable artifact on Maven Central.With this change, re-running the identical command shows
Skipping artifact deploymentforfesod-benchmark, and only the 5 release modules (fesod-parent,fesod-bom,fesod-common,fesod-shaded,fesod-sheet) reach the repository. The module still builds, shades and installs normally, so benchmark CI and JMH workflows are unaffected.This matches the common Apache practice of excluding benchmark/test-only modules from deployment.
Checklist